-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve location of config files #10
Comments
Can you make a patch for these fixes?
… On Jun 20, 2017, at 08:44, Diederik de Haas ***@***.***> wrote:
In you instructions you place a config file directly in /etc/ which you shouldn't do. Create a dedicated directory for your configuration files, say something like /etc/canaan/.
A bit further down, you give the following direction:
sudo cp ams-git/config/000-default.conf /etc/apache2/sites-available/000-default.conf
Not only is config/000-default.conf NOT available in the master branch (it is in the source code download), but 'blindly' overwriting the default configuration file which is already present, is not the way to do it.
Create your own config file with a unique name and copy that to sites-available and then enable it with a2ensite would be major improvement.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Not anytime soon. |
Yes, it is worked on, but our communication is not good. RIght @qinfengling ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In you instructions you place a config file directly in
/etc/
which you shouldn't do. Create a dedicated directory for your configuration files, say something like/etc/canaan/
.A bit further down, you give the following direction:
sudo cp ams-git/config/000-default.conf /etc/apache2/sites-available/000-default.conf
Not only is
config/000-default.conf
NOT available in the master branch (it is in the source code download), but 'blindly' overwriting the default configuration file which is already present, is not the way to do it.Create your own config file with a unique name and copy that to
sites-available
and then enable it witha2ensite
would be major improvement.The text was updated successfully, but these errors were encountered: