Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping react-mosaic version #393

Merged
merged 1 commit into from
May 12, 2022
Merged

Dropping react-mosaic version #393

merged 1 commit into from
May 12, 2022

Conversation

dvzacharycutler
Copy link

@dvzacharycutler dvzacharycutler commented May 12, 2022 •
edited
Loading

Closes list issues numbers here

Developer Checklist (Definition of Done)

  • Descriptive title for this pull request provided (will be used for release notes later)
  • All acceptance criteria from the issue are met
  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Code documentation written
  • Unit tests written
  • Tested in Chrome
  • Tested in Firefox
  • Build is successful
  • Summary of changes written
  • Wiki documentation written
  • Assign at least one reviewer
  • Assign at least one assignee
  • Add type label (e.g., bug, enhancement) to this pull request
  • Add next version label (e.g., next-version: minor) to this PR following semver

Summary of changes

Screenshots

@dvzacharycutler dvzacharycutler requested a review from thinkh as a code owner May 12, 2022 15:44
@dvzacharycutler dvzacharycutler changed the title dropping mosaic version to fix bug Dropping react-mosaic version May 12, 2022
dvchristianbors
dvchristianbors approved these changes May 12, 2022
View reviewed changes
Copy link

@dvchristianbors dvchristianbors left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with local prototype, app crashes no longer occur with older react-mosaic

@dvchristianbors dvchristianbors merged commit ea36d60 into ordino-2.0 May 12, 2022
@dvchristianbors dvchristianbors deleted the zc/mosaic-version branch May 12, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvchristianbors dvchristianbors dvchristianbors approved these changes

@thinkh thinkh Awaiting requested review from thinkh thinkh is a code owner

Assignees

@dvchristianbors dvchristianbors

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvzacharycutler @dvchristianbors