Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOT YET] Refactor module export #8

Open
Shelob9 opened this issue Jul 4, 2018 · 0 comments
Open

[NOT YET] Refactor module export #8

Shelob9 opened this issue Jul 4, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@Shelob9
Copy link
Contributor

Shelob9 commented Jul 4, 2018

I'm not in love with how the export is handled.

I prefer this pattern -

https://github.com/CalderaWP/caldera-components/blob/master/src/components/validation/index.js

https://github.com/CalderaWP/caldera-components/blob/master/src/components/validation/export.test.js
@Shelob9 Shelob9 mentioned this issue Jul 4, 2018
Closed
8 tasks
@Shelob9 Shelob9 added enhancement New feature or request help wanted Extra attention is needed labels Jul 17, 2018
@Shelob9 Shelob9 changed the title Refactor module export [NOT YET] Refactor module export Jul 17, 2018
@Shelob9 Shelob9 removed the help wanted Extra attention is needed label Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shelob9