-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace main admin screen with a shiny new React and REST API-driven web app #2707
Open
Shelob9
wants to merge
24
commits into
develop
Choose a base branch
from
project/admin-refactor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/caldera-forms into project/admin-refactor * 'project/admin-refactor' of https://github.com/CalderaWP/caldera-forms: hacky solution to avoid loading old assets in admin #2445 Hi roy commit for new admin app #2445 restart admin client # Conflicts: # package.json # vendor/autoload.php # vendor/calderawp/caldera-containers/.travis.yml # vendor/calderawp/caldera-containers/README.MD # vendor/calderawp/caldera-containers/Tests/ServiceServiceContainerTest.php # vendor/calderawp/caldera-containers/composer.json # vendor/calderawp/caldera-containers/src/Service/Container.php # vendor/calderawp/caldera-forms-query # vendor/composer/autoload_classmap.php # vendor/composer/autoload_real.php # vendor/composer/autoload_static.php # vendor/composer/installed.json
* feature/857: #857 add clone argument for create form Use original args as default when cloning a form #1282 Add api endpoint for toggling active status of a form #857 more work on create form endpoint #857 Add create from REST API endpoint #857 # Conflicts: # classes/api/forms.php # classes/api/response_factory.php
@Shelob9 This generates the build version of index.scss, the clients/admin/build/style.min.css still needs to be enqueued and I'm not sure if we want to enqueue css files from the clients folder or move theme and enqueue from the assets folder. BTW, the admin client is loading these styles via import within the index.js file, once we decide where we enqueue css from we can remove the import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/CalderaWP/Caldera-Forms/projects/4
#2445