Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild main admin page #2445

Open
Shelob9 opened this issue Apr 19, 2018 · 5 comments
Open

Rebuild main admin page #2445

Shelob9 opened this issue Apr 19, 2018 · 5 comments
Assignees
Labels
enhancement New feature
Milestone

Comments

@Shelob9
Copy link
Collaborator

Shelob9 commented Apr 19, 2018

Some initial work will get merged with #2444 but not used.

@Shelob9 Shelob9 added the enhancement New feature label Apr 19, 2018
@Shelob9 Shelob9 added this to the 1.7.0 milestone Apr 19, 2018
@Shelob9 Shelob9 self-assigned this Apr 19, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.0, 1.7.1 May 23, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.1, 1.7.2 Jun 4, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.2, 1.7.3 Jun 25, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.3, 1.8.0 Jul 5, 2018
Shelob9 pushed a commit that referenced this issue Aug 19, 2018
Shelob9 pushed a commit that referenced this issue Aug 19, 2018
Shelob9 pushed a commit that referenced this issue Aug 22, 2018
…/caldera-forms into project/admin-refactor

* 'project/admin-refactor' of https://github.com/CalderaWP/caldera-forms:
  hacky solution to avoid loading old assets in admin
  #2445 Hi roy commit for new admin app
  #2445 restart admin client

# Conflicts:
#	package.json
#	vendor/autoload.php
#	vendor/calderawp/caldera-containers/.travis.yml
#	vendor/calderawp/caldera-containers/README.MD
#	vendor/calderawp/caldera-containers/Tests/ServiceServiceContainerTest.php
#	vendor/calderawp/caldera-containers/composer.json
#	vendor/calderawp/caldera-containers/src/Service/Container.php
#	vendor/calderawp/caldera-forms-query
#	vendor/composer/autoload_classmap.php
#	vendor/composer/autoload_real.php
#	vendor/composer/autoload_static.php
#	vendor/composer/installed.json
@Shelob9
Copy link
Collaborator Author

Shelob9 commented Oct 17, 2018

@New0

OK, I'm ready to hand this one to you. I copied in most of the plugin I was using to develop this, we are no longer using that repo. Just Caldera Forms.

Todos for @New0 after 05d8c74

Todos for @Shelob9 after 05d8c74

  • Fix webpack so WordPress components import properly (this is why clicking Settings button breaks everything BTW)
  • Figure out temporary solution for entry viewer
  • Remove old pro Ui
    • Remove page
    • Remove client
  • Pro settings in CF editor tab
  • Make Form Editor not totally break (its happening because editor needs old admin.js which is no longer enqueued) Make which admin script loads determined by filter #2789

@Shelob9
Copy link
Collaborator Author

Shelob9 commented Oct 17, 2018

Pretty sure to add CSS compilation from clients/admin.index.scss to clients/admin/build/style.css we would need to add a CSS loader in webpack

new ExtractTextPlugin( {
  filename: '.clients/admin.index.scss',
} );

and also fix the saas loader.

https://github.com/zgordon/how-to-gutenberg-plugin/blob/master/webpack.config.js

Shelob9 pushed a commit that referenced this issue Oct 18, 2018
@Shelob9
Copy link
Collaborator Author

Shelob9 commented Oct 23, 2018

For the tabs import { TabPanel } from '@wordpress/components'; https://github.com/WordPress/gutenberg/tree/master/packages/components/src/tab-panel

@Shelob9
Copy link
Collaborator Author

Shelob9 commented Oct 23, 2018

Form search #1912 and orderby #1911

Shelob9 referenced this issue Oct 24, 2018
@Shelob9 This generates the build version of index.scss, the clients/admin/build/style.min.css still needs to be enqueued and I'm not sure if we want to enqueue css files from the clients folder or move theme and enqueue from the assets folder.
BTW, the admin client is loading these styles via import within the index.js file, once we decide where we enqueue css from we can remove the import.
@Shelob9 Shelob9 modified the milestones: 1.8.0, 1.9.0 Nov 6, 2018
@Shelob9
Copy link
Collaborator Author

Shelob9 commented Apr 2, 2019

@New0 here is the new mockup I promised:

IMG_20190402_120648

These are notes corresponding to the numbers in the image:

  1. Form list component exists - https://github.com/CalderaWP/caldera-js/tree/master/packages/components/src/components/elements/FormsList
  2. New form, import and settings we do not have components for, would need to make those using HorizontalForm
  3. Doc search. This is important. We could reuse this: https://github.com/CalderaWP/caldera-forms-docs-search/blob/master/src/DocSearch.js
  4. These bars are clickable -- probably need button to make that. This an accordion.
  5. I'd love to get the new logo in there now. Depends on if we can re-brand the site that quickly or not.

Also:

Shelob9 pushed a commit that referenced this issue May 29, 2019
@New0 New0 modified the milestones: 1.9.0, 1.9.1, 1.9.2 Jun 18, 2020
@New0 New0 modified the milestones: 1.9.2, 1.9.3 Jul 15, 2020
@New0 New0 modified the milestones: 1.9.3, 1.9.5 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

No branches or pull requests

2 participants