Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rawmarshmellows
Copy link

Best practices to import with "*", also fixes my use case of automatically generate lookup dictionary by having the names of the models being exported:

from pretrainedmodels.models import __all__ as pretrained_models_names

pretrained_models_lookup = {
    name: getattr(importlib.import_module("pretrainedmodels.models"), name)
    for name in pretrained_models_names
}

lookup = {**pretrained_models_lookup}

Best practices to import with "*", also fixes my use case of automatically generate lookup dictionary by having the names of the models being exported:

```
from pretrainedmodels.models import __all__ as pretrained_models_names

pretrained_models_lookup = {
    name: getattr(importlib.import_module("pretrainedmodels.models"), name)
    for name in pretrained_models_names
}

lookup = {**pretrained_models_lookup}
```
@Cadene
Copy link
Owner

Cadene commented Aug 5, 2019

Thanks!
I'll look into it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants