Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent traces as array rather than dictionary #28

Open
trombonehero opened this issue May 14, 2015 · 0 comments
Open

Represent traces as array rather than dictionary #28

trombonehero opened this issue May 14, 2015 · 0 comments

Comments

@trombonehero
Copy link
Member

SOAAP currently names [sub]traces in the call graph using string names and puts them into the top-level SOAAP object. It might ease the complexity burden a bit if we instead put an array of traces into the top-level object and referred to each trace by index within this array instead of by name.

That is, instead of:

"vulnerability_warning": [
  {
    "function": "_ZNK6SkMask16computeImageSizeEv",
    "sandbox": "capsicum",
    /* ... */
    "trace_ref": "!trace0"
  }
],
"!trace0": {
    "name": "!trace0",
    "trace": [
      {
        "function": "_ZNK6SkDraw16drawBitmapAsMaskERK8SkBitmapRK7SkPaint",
        "location": /* ... */
      },
      {
        "trace_ref": "!trace311968"
      }
    ]
  },
}

we could have:

"vulnerability_warning": [
  {
    "function": "_ZNK6SkMask16computeImageSizeEv",
    "sandbox": "capsicum",
    /* ... */
    "trace_ref": 0
  }
],
"traces": [
  [
    {
      "function": "_ZNK6SkDraw16drawBitmapAsMaskERK8SkBitmapRK7SkPaint",
      "location": /* ... */
    },
    {
      "trace_ref": 311968
    }
  ],  
  /* ... */
]
@trombonehero trombonehero changed the title Incorporate cap_enter in SOAAP model of Capsicum Represent traces as array rather than dictionary May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant