Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The blocked status is not automatically removed when the block period ends. #86

Open
elenalshv opened this issue Jul 26, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@elenalshv
Copy link

Steps to Reproduce the Bug:

  1. Log in.
  2. Navigate to the "Equipment" section.
  3. Click on the "Block" button. A modal window titled "Equipment blocking" appears.
  4. Select the block dates.
  5. Click the "Block" button.
  6. The equipment status changes to "Blocked."
  7. After the block period ends, the "Blocked" status should automatically change to "Available."
@elenalshv elenalshv added this to Kanban Jul 26, 2024
@elenalshv elenalshv moved this to Backlog in Kanban Jul 26, 2024
@wvxiw8 wvxiw8 assigned wvxiw8 and unassigned WolfusFlow, smailic05 and wvxiw8 Jul 26, 2024
@ZharIvan ZharIvan moved this from Backlog to In progress in Kanban Jul 29, 2024
@wvxiw8
Copy link
Contributor

wvxiw8 commented Jul 29, 2024

@IanaVagner @ZharIvan
Is unblocking really done automatically or a manager must confirm unblocking and do it manually?

@IanaVagner
Copy link

@IanaVagner @ZharIvan Is unblocking really done automatically or a manager must confirm unblocking and do it manually?

We have two possible scenarios:

-Automatic unblocking occurs after the block period expires.
-Manual unblocking occurs at the user's discretion. If it is necessary to cancel the block in the future or to end the block period immediately, the user can use the "Unblock" button for these purposes.

@wvxiw8 wvxiw8 added the feature label Jul 30, 2024
@wvxiw8
Copy link
Contributor

wvxiw8 commented Aug 27, 2024

@IanaVagner what should we do with orders which have been waiting for the equipment to be unblocked?

When we were blocking the equipment we checking if it has orders within current time and status "prepared" or "approved". Then we set to those orders the new status "Blocked". So we loose the previous status of the orders.

Currently the UnblockEquipment() (it's not the same function as for the issue, there will be another function for unblocking expired blockings) doesn't do anything with the blocked orders for the blocked equipment, so this might be kind of a resource leak. Are such blocked orders managed manually? If so, will we also manage them manually in this case and just leave "blocked"?

@wvxiw8
Copy link
Contributor

wvxiw8 commented Sep 4, 2024

@ZharIvan maybe you can provide some info about my previous question

@wvxiw8
Copy link
Contributor

wvxiw8 commented Sep 11, 2024

@ZharIvan @IanaVagner
We have a configured variable for a time interval to periodically check for overdue - OrderStatusOverdueTimeCheckDuration. I think we can use the same period to check for expired blockings, can we? I can rename the variable to something like PeriodicalCheckDuration.
Or do we need to use a separate variable for it?

@wvxiw8
Copy link
Contributor

wvxiw8 commented Sep 11, 2024

Concerning my questions above we decided to

  1. Do not do anything with orders for equipment which blocking period expired. This will be a manual operation (after calling to customers)
  2. Have a common configuration variable for periodical checkings

wvxiw8 added a commit that referenced this issue Sep 11, 2024
wvxiw8 added a commit that referenced this issue Sep 11, 2024
wvxiw8 added a commit that referenced this issue Sep 12, 2024
WolfusFlow added a commit that referenced this issue Sep 12, 2024
…tomatically_removed_when_block_period_ends
@wvxiw8 wvxiw8 moved this from In progress to Done in Kanban Sep 12, 2024
@wvxiw8 wvxiw8 closed this as completed by moving to Done in Kanban Sep 12, 2024
@elenalshv
Copy link
Author

The reservation for one day, the entry should be from 00:00:00 to 23:59:59 on the same day, at 00:00:00 the next day the blocking should be automatically canceled.

@elenalshv elenalshv reopened this Sep 23, 2024
@elenalshv elenalshv added bug Something isn't working and removed feature labels Sep 23, 2024
@elenalshv elenalshv moved this from Done to Needs fix after testing in Kanban Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Needs fix after testing
Development

No branches or pull requests

5 participants