Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #3327

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Small fixes #3327

merged 8 commits into from
Nov 4, 2024

Conversation

Macroz
Copy link
Collaborator

@Macroz Macroz commented Sep 11, 2024

Implements small fixes.

Sorting should be checked manually still.

Close #3299
Close #3301
Close #3292
Close #3302

A few buttons are made to show the icon first (like elsewhere). Also a missing space is added between the icon and the text.

rems_switch_icons

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Consider adding screenshots for ease of review

Documentation

  • Update changelog if necessary
  • API is documented and shows up in Swagger UI

Testing

  • Valuable features are integration / browser / acceptance tested automatically

@Macroz
Copy link
Collaborator Author

Macroz commented Sep 16, 2024

Created https://github.com/orgs/CSCfi/projects/13?pane=issue&itemId=79888572

Copy link
Collaborator

@aatkin aatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 👍 while testing i noticed an issue with collapsible toggle and created a separate PR fix in #3329

src/cljs/rems/administration/create_workflow.cljs Outdated Show resolved Hide resolved
src/cljs/rems/administration/create_license.cljs Outdated Show resolved Hide resolved
@Macroz Macroz merged commit 4912567 into master Nov 4, 2024
7 checks passed
@Macroz Macroz deleted the small-fixes branch November 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants