-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update typing #790
Conversation
Why should we use Which makes me think that perhaps we should set |
There was a mix of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what @csc-felipe commented is a good point. If we're updating the typing, we might as well do it with the current best practice while we're at it (as long as it's not an unnecessarily long task). So while the built-in typing
class still exists, it's been deprecated by now as proposed in PEP 585. So you would have list
, dict
etc. or then collections.abc.Callable
and collections.abc.Iterator
.
However, it seems the types Any
, Optional
, TypedDict
and TypeVar
which we still have in our code (at least I found in this PR) are still to be imported from typing
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Approved, but you still have to click on the three dots > dismiss review from Joonatan's requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now everything looks good to me as well :P
Description
Updated type annotations all around. Mostly changed dict and list type annotations to be Dict[something] and List[something].
Related issues
Fixes #789 github workflows
Type of change
Testing