Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mypyconfig #789

Closed
wants to merge 2 commits into from
Closed

Feature/mypyconfig #789

wants to merge 2 commits into from

Conversation

gimppa
Copy link
Contributor

@gimppa gimppa commented Aug 23, 2023 •
edited
Loading

Description

Added mypy configuration to pyproject.toml, to make programming environments among developers more consistent.

This breaks github workflows, because of increased strictness of type checking. Updating typing is work in progress.

Type of change

  • New feature (breaking change which adds functionality)

Testing

  • Tests do not apply

@gimppa gimppa self-assigned this Aug 23, 2023
csc-jm
csc-jm approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@csc-jm csc-jm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the github pipeline gets fixed after this pr, then I approve as well

@gimppa gimppa mentioned this pull request Aug 29, 2023
Merged
2 tasks
@csc-felipe
Copy link
Contributor

I think we can close this, as #790 includes these changes.

@csc-felipe csc-felipe closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csc-jm csc-jm csc-jm approved these changes

@blankdots blankdots blankdots approved these changes

@csc-felipe csc-felipe Awaiting requested review from csc-felipe

Assignees

@gimppa gimppa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gimppa @csc-felipe @blankdots @csc-jm