Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API moved to /v1 #826

Open
csc-felipe opened this issue Jun 9, 2022 · 0 comments
Open

API moved to /v1 #826

csc-felipe opened this issue Jun 9, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@csc-felipe
Copy link
Contributor

Proposed solution

There are some more breaking changes in the backend from this PR CSCfi/metadata-submitter#476

  • API is now under /v1
  • /logout doesn't redirect to frontend any more, it returns 204
  • Only API routes are checked for session authentication, so frontend now has to check it. Other routes are public

Public routes are:

  • /aai
  • /callback
  • /logout
  • /health
  • /static
  • / - with catch-all, so any routes not matching other routes will return the frontend files, so maybe frontend needs to handle routing differently

DoD (Definition of Done)

Frontend works against backend commit be0002c, which is the last commit in develop at the time of creating this issue.

Testing

Tests pass again ^^

@csc-felipe csc-felipe added the enhancement New feature or request label Jun 9, 2022
@lilachic lilachic self-assigned this Jun 14, 2022
@lilachic lilachic mentioned this issue Jun 16, 2022
6 tasks
@lilachic lilachic linked a pull request Jun 16, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants