Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/form and xml changes #811

Merged
merged 12 commits into from
May 31, 2022
Merged

Feature/form and xml changes #811

merged 12 commits into from
May 31, 2022

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented May 24, 2022 •
edited
Loading

Description

Introduced new structure of Form, new way of showing Tooltip and new way to upload and show XML File.

Related issues

Closes #540, #541, #787

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

  • Converted the Form into new layout by mainly refactoring FormSection in WizardJSONSchemaParser.tsx
  • Remade Tooltip with reusable component DisplayDescription, limited the default description text length to 60 chars with option to Read more/Expand text
  • Added Options including Upload XML and Clear form to Form
  • Changed form's action buttons to Save as draft and Mark as ready
  • Added modal for selecting/drag-dropping XML file
  • Added a new page for showing information of selected XML file
  • Fixed a bug about refreshing and starting a new form whenever we click Add <object> button
  • Update unit test for Tooltip
  • Update e2e tests for Form

Testing

  • Unit Tests
  • Integration Tests

Mentions

@hannyle hannyle self-assigned this May 24, 2022
@hannyle hannyle force-pushed the feature/form-and-xml-changes branch 2 times, most recently from ea97490 to 61b57fd Compare May 25, 2022 05:57
@hannyle
Copy link
Contributor Author

hannyle commented May 25, 2022

e2e test for Upload XML will be implementation in another PR with this issue: #652

@hannyle hannyle requested review from lilachic and rquazi May 25, 2022 08:22
@hannyle hannyle added enhancement New feature or request new frontend labels May 25, 2022
This was linked to issues May 25, 2022
New tooltip design for form fields #540
Open
Redesigned form layout #541
Open
Implement design for XML upload #787
Closed
@hannyle hannyle mentioned this pull request May 25, 2022
Open
@hannyle hannyle force-pushed the feature/form-and-xml-changes branch from 5af4929 to 42818c3 Compare May 27, 2022 12:11
@lilachic
Copy link
Contributor

Wondering if this meant the tooltips to be rendered on the left of the question mark icon
Screenshot 2022-05-27 at 18 02 30
?

@hannyle hannyle requested a review from saulipurhonen May 30, 2022 07:21
@saulipurhonen
Copy link
Contributor

Maybe change cursor to "pointer" when hovering "Read more/Expand" link?
image

@saulipurhonen
Copy link
Contributor

saulipurhonen commented May 31, 2022 •
edited
Loading

Wondering if this meant the tooltips to be rendered on the left of the question mark icon

This seems to be related to browser size. Tooltip is rendered on right side of the indicator on larger resolutions.

saulipurhonen
saulipurhonen approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@saulipurhonen saulipurhonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written and easy to understand. LGTM!

@hannyle
Copy link
Contributor Author

hannyle commented May 31, 2022

Wondering if this meant the tooltips to be rendered on the left of the question mark icon

This seems to be related to browser size. Tooltip is rendered on right side of the indicator on larger resolutions.

Yes that's related to browser size.

@hannyle hannyle force-pushed the feature/form-and-xml-changes branch from 58c065f to f45ce89 Compare May 31, 2022 12:00
@hannyle hannyle merged commit 656f071 into develop May 31, 2022
@hannyle hannyle deleted the feature/form-and-xml-changes branch May 31, 2022 13:01
@hannyle hannyle mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulipurhonen saulipurhonen saulipurhonen approved these changes

@lilachic lilachic Awaiting requested review from lilachic

@rquazi rquazi Awaiting requested review from rquazi

Assignees

@hannyle hannyle

Labels
enhancement New feature or request new frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesigned form layout New tooltip design for form fields Implement design for XML upload
3 participants
@hannyle @lilachic @saulipurhonen