Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback on week 9 project progress #68

Open
23 of 28 tasks
nus-se-bot opened this issue Mar 20, 2019 · 13 comments
Open
23 of 28 tasks

Feedback on week 9 project progress #68

nus-se-bot opened this issue Mar 20, 2019 · 13 comments

Comments

@nus-se-bot
Copy link

nus-se-bot commented Mar 20, 2019 •
edited by EugeneYiren
Loading

Subject: feedback on week 9 project progress

See v1.2 progress guide for more details of the activities mentioned below.

Team progress

Recommended progress for v1.2

  • Issue labels* set up e.g., type.* and priority.* (:heavy_check_mark: well done!)
  • All milestones v1.2, v1.3, v1.4, created (:heavy_check_mark: well done!)
  • Issues marked as type.Story e.g., link (:heavy_check_mark: well done!)
  • Some issues prioritized using priority.* labels e.g., link (:heavy_check_mark: well done!)
  • Milestone v1.2 managed systematically
    • A suitable deadline** set (:exclamation: try to do by next milestone)
    • Issues allocated to v1.2 e.g., link (:heavy_check_mark: well done!)
    • All issues/PRs in it are closed/merged (:exclamation: try to do by next milestone)
    • Milestone closed (:exclamation: try to do by next milestone)
    • Code tagged as v1.2 (:exclamation: try to do by next milestone)
  • Build passing link (:exclamation: try to do by next milestone)
  • Some issues assigned to milestone v1.3 e.g., link (:heavy_check_mark: well done!)

*Remember to use the format specified, else it will not be picked up by the bot
**Remember that the deadline is the midnight before your tutorials

Not graded:

  • Updated User Guide for v1.2 (:+1: Kudos!)

Individual progress of @PhilipPhil

Follow up from v1.1

  • Used forking workflow:
    • Created PRs link (:heavy_check_mark: well done!)
    • Gave review comments to other PRs (:heavy_check_mark: well done!)
  • Merged updates to documents (:exclamation: try to do by next milestone)
  • philipphil.png uploaded and linked from AboutUs page in png format (change image to png if presently in different format) (:heavy_check_mark: well done!)

Recommended progress for v1.2

  • Merged updates to java/fxml files (:heavy_check_mark: well done!)
  • Merged updates to the Developer Guide (:exclamation: try to do by next milestone)
  • Has issues/PRs assigned for the milestone (:exclamation: try to do by next milestone)

Individual progress of @rafflesandrison

Recommended progress for v1.2

  • Merged updates to java/fxml files (:heavy_check_mark: well done!)
  • Merged updates to the Developer Guide (:heavy_check_mark: well done!)
  • Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @stanleymok

Recommended progress for v1.2

  • Merged updates to java/fxml files (:heavy_check_mark: well done!)
  • Merged updates to the Developer Guide (:exclamation: try to do by next milestone)
  • Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @reinsheer

Recommended progress for v1.2

  • Merged updates to java/fxml files (:heavy_check_mark: well done!)
  • Merged updates to the Developer Guide (:exclamation: try to do by next milestone)
  • Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Tutor: @leeyh20

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2019-03-20 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.
@PhilipPhil
Copy link

PhilipPhil commented Mar 27, 2019 via email

@PhilipPhil
Copy link

PhilipPhil commented Mar 27, 2019 via email

@nus-se-bot
Copy link
Author

Hi @PhilipPhil ,

Kindly provide us with the links to the PRs which contain your contributions for the associated checks that you mention above. We will then be able to check them manually.

Thanks,
CS2103-feedback-team

@PhilipPhil
Copy link

PhilipPhil commented Mar 28, 2019 via email

@stanleymok
Copy link

stanleymok commented Mar 28, 2019 via email

@stanleymok
Copy link

LOL god bless i didnt know this was a comment thread thought it was an email my bad

@PhilipPhil
Copy link

No worries thanks for looking out for me

@stanleymok
Copy link

stanleymok commented Mar 28, 2019 via email

@nus-se-bot
Copy link
Author

Hi @PhilipPhil ,

Kindly provide us with some of the merged PR links (not commit links) that you created. As the workflow suggests contribution to be made through PRs, the bot only considers merged PRs.

Thanks,
CS2103-feedback-team

@PhilipPhil
Copy link

PhilipPhil commented Mar 30, 2019 via email

@kylase-learning
Copy link

RepoSense is run daily now.

To all, .json file has been updated with his sourcetree name & merged with team repo. Probably should wait till next Monday when repoSense gets updated before proceeding with further fix. Also please dereference/unmention me from this chain of emails. Regards, Stanley Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10 From: Philip Garabandicmailto:[email protected] Sent: Thursday, March 28, 2019 6:11 PM To: CS2103-AY1819S2-W15-1/mainmailto:[email protected] Cc: Stanley Joseph Mokmailto:[email protected]; Mentionmailto:[email protected] Subject: Re: [CS2103-AY1819S2-W15-1/main] Feedback on week 9 project progress(#68) Here are some of them. I made a lot of commits so I probably missed sum. But I think the links I added are enough to meet the check marks. 26ff616 ba40d0a 351acfa 9901884 786195d d41ba48 8ab7879 e7eb969 51fc0c9 131cb87 131cb87 75603e1 fac81c4 PhilipPhil@cdec290 PhilipPhil@f616c0e PhilipPhil@f616c0e PhilipPhil@d838af5 PhilipPhil@5fdbed6 PhilipPhil@daa7588 PhilipPhil@c49b2e0 PhilipPhil@1dd7c9d
On Wed, 27 Mar 2019 at 22:03, CS2103-feedback-bot @.***> wrote: Hi @PhilipPhil https://github.com/PhilipPhil , Kindly provide us with the links to the PRs which contain your contributions for the associated checks that you mention above. We will then be able to check them manually. Thanks, CS2103-feedback-team — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AqvGEiAreyAOIGPvdG6HQGRX8lSdot7hks5va3orgaJpZM4b_wM4 .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#68 (comment)>, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ApvnSwBxT4wPpolx_MK4F_tGiANJfFtBks5vbJVRgaJpZM4b_wM4.

@ccristina
Copy link

ccristina commented Apr 5, 2019 •
edited
Loading

Hi,

No worries about week 6 & 8 as they are not graded milestones.

Same as for week 6 was done but this was not green. - PRs created to update Java code (❗️ try to do by next milestone) was done but not marked. Thank you.
…

Best regards,
Cristina.

@ccristina
Copy link

Hi @PhilipPhil,

I can't find any update on the UG or DG made by you for v1.2. Could you provide the link of the commit for updated on the DOCUMENTS, if any?

Also, I can't see any issue assigned to you for v1.2. Could you provide the link of the issues, if any?

For week 8 and week 9

  • Merged updates to documents (❗️ try to do by next milestone) and
  • Merged updates to the Developer Guide (❗️ try to do by next milestone)
  • Has issues/PRs assigned for the milestone (❗️ try to do by next milestone)
    Could I get some help on getting that fixed. Thank you.
    …

Let us know if you have further questions. .

Thanks,
Cristina.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ccristina @kylase-learning @nus-se-bot @stanleymok @PhilipPhil