Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion of exception messages to constants #84

Closed
simjiazhi opened this issue Mar 11, 2019 · 1 comment
Closed

Conversion of exception messages to constants #84

simjiazhi opened this issue Mar 11, 2019 · 1 comment
Assignees
@simjiazhi
Labels
priority.low type.tasks Tasks to be completed or feature to be added towards a milestone
Milestone
Milestone v1.3

Comments

@simjiazhi
Copy link

simjiazhi commented Mar 11, 2019 •
edited
Loading

Exception messages are now hard-coded in command and parser classes in patient and consultation module. Converting them to constants reduces the long term copy-pasting of these string sequences.

Satisfy #49 #50 #51 #54 #82
@simjiazhi simjiazhi added type.tasks Tasks to be completed or feature to be added towards a milestone priority.low labels Mar 11, 2019
@simjiazhi simjiazhi added this to the Milestone v1.2 milestone Mar 11, 2019
@simjiazhi simjiazhi self-assigned this Mar 11, 2019
@simjiazhi
Copy link
Author

Also need to make sure format is displayed whenever a erroneously structured command is entered. Moving to milestone 1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simjiazhi simjiazhi

Labels
priority.low type.tasks Tasks to be completed or feature to be added towards a milestone
Projects
None yet
Milestone
Milestone v1.3
Development

No branches or pull requests
1 participant
@simjiazhi