Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar Chart Graph for Statistics Screen #24

Open
yaswant2403 opened this issue Nov 21, 2024 · 2 comments
Open

Bar Chart Graph for Statistics Screen #24

yaswant2403 opened this issue Nov 21, 2024 · 2 comments

Comments

@yaswant2403
Copy link
Collaborator

yaswant2403 commented Nov 21, 2024

Currently, the statistics screen works with the Bar Chart without the main branch code. However, once we merged the main branch into the pranay's branch, the bar chart doesn't look as good as it did on the web version.

So, your following tasks are:

  • Using the incident types from the constants folder and incident interface from the types folder in the statistics screen
  • Incidents Filter
  • improve styling for iOS and Android devices. Functionality exists with Firebase intergrated
@yaswant2403
Copy link
Collaborator Author

yaswant2403 commented Nov 21, 2024

A little better but this doesn't showcase all types of incidents on the chart. Maybe allowing user to either scroll on the histogram itself could be a way to have them see different types of incidents if it's not possible to display all types at once

The y-axis counts seem to repeat (Count 1 being displayed multiple times)

image

@yaswant2403
Copy link
Collaborator Author

0f0b2d1 addresses previous issues. One additional improvement would be the following:

  • Use the incident and severity labels from import { INCIDENT_TYPE_LABELS, SEVERITY_LEVEL_LABELS, PIN_COLORS } from '@/constants/Incidents' rather than hard-coding them. This just ensures we're using the same labels throughout all the screens. If you don't have this file, you can copy it from the main branch

Will test this code on main branch and see if any other improvements can be made, but great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants