Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension is broken, schema doesn't resolve #6

Closed
m-mohr opened this issue Sep 12, 2024 · 7 comments
Closed

Extension is broken, schema doesn't resolve #6

m-mohr opened this issue Sep 12, 2024 · 7 comments

Comments

@m-mohr
Copy link

m-mohr commented Sep 12, 2024

The schema https://stac-extensions.github.io/eopf/v1.0.0/schema.json doesn't resolve.

@carinequang
Copy link
Collaborator

Many thanks for raising this issue. Indeed, the link is incorrect. But we need to update the schema first (see issue #7 ) and upgrade the version, then we will publish the correct link. It should be done by next week.

Thank you in advance for your patience,
Best regards

@cs-cquang
Copy link

Dear @m-mohr,
EOPF stac extension version has been upgraded to v1.1.0.
As it is not yet published on the official stac extensions github, the link to the json schema is the one published on our CS github.

Kind regards
Carine

@m-mohr
Copy link
Author

m-mohr commented Oct 8, 2024

Thankjs, but the given link is still not working correctly for me, sorry. @cs-cquang

https://raw.githubusercontent.com/CS-SI/eopf-stac-extension/refs/tags/v1.1.0/json-schema/schema.json returns a text document, not a JSON document (see HTTP headers). If I request a JSON document via HTTP content negotiation I get an error. Please try what you are publishing with a STAC validator such as stac-node-validator CLI.

You should properly set up the GH Pages based extension deployment as in the original STAC extension template. For this it doesn't need to be part of the stac-extensions organization. Ideally you'd have https://CS-SI.github.io/eopf-stac-extension/v1.2.0/schema.json in the end.

@BenEsquis
Copy link
Collaborator

Dear @m-mohr

github pages have been setup
json-schema have been linted

Regards

@m-mohr
Copy link
Author

m-mohr commented Oct 15, 2024

Thanks, but the JSON Schema still refers to https://github.com/CS-SI/eopf-stac-extension/raw/refs/tags/v1.1.0/json-schema/schema.json instead of https://cs-si.github.io/eopf-stac-extension/v1.2.0/schema.json

Example is also outdated: https://github.com/CS-SI/eopf-stac-extension/blob/main/examples/item.json

So I guess you are not running the test CI at all? Please update the full extension, incl. schema, examples and README, validate it using npm test.

@BenEsquis
Copy link
Collaborator

Dear @m-mohr

Thanks for the feedback

Example has been updated and is validating the npm tests
CI has been setup
If you see anything else

Regards

@m-mohr
Copy link
Author

m-mohr commented Oct 16, 2024

Thanks, looks good to me.

@m-mohr m-mohr closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants