Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift evolution in PhotoPionProduction #254

Closed
lukasmerten opened this issue Nov 18, 2019 · 1 comment · Fixed by #255
Closed

Redshift evolution in PhotoPionProduction #254

lukasmerten opened this issue Nov 18, 2019 · 1 comment · Fixed by #255
Assignees
Labels

Comments

@lukasmerten
Copy link
Member

Description

It seems that the redshift evolution is ignored in the current implementation of the PhotoPionProduction. Even for non CMB target fields the redshift dependence is turned off as for intended for the CMB.

void PhotoPionProduction::setPhotonField(PhotonField field) { photonField = field; if (haveRedshiftDependence) { std::cout << "PhotoPionProduction ... " << std::endl; haveRedshiftDependence == false; } ... }

To Reproduce
from crpropa import *
EBL = IRB_Finke10
PPP = PhotoPionProduction(EBL, True, True, True, True, 0.1, True)

Expected behavior
No output

I have not checked any simulation results. However, the file rate_IRBz_Finke10.txt is not opened as I would have expected when including the redshift evolution.

@MHoerbe
Copy link
Contributor

MHoerbe commented Nov 19, 2019

Thanks for bringing this up, your findings are correct. See #255 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants