-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spider tn #157
base: main
Are you sure you want to change the base?
Spider tn #157
Conversation
@kinianlo Hi and thanks for the PR. In general, I think it's better to avoid any hidden manipulation at the tensor network level, since physical changes of this form can alter dramatically training. Perhaps a better solution here would be a spider-specific tensor ansatz which arranges the spiders reader output e.g. as follows, producing a chain of 3-legged spiders.
|
@@ -46,3 +48,4 @@ def sentence2diagram(self, | |||
|
|||
spiders_reader = SpidersReader() | |||
bag_of_words_reader = spiders_reader | |||
spider_chain_reader = LinearReader(Spider(AtomicType.SENTENCE, 2, 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LinearReader
requires a Diagram
type but Spider
is a Box
. Should LinearReader be modified to also accept Box
or we should convert the Spider into a diagram, e.g. using .to_diagram()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use .to_diagram()
for now. Please also note that your branch requires some cleaning.
An attempt to fix #156