Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Applying i18Next translations #721

Open
1 task done
AdhamAH opened this issue May 18, 2020 · 2 comments
Open
1 task done

[FEAT] Applying i18Next translations #721

AdhamAH opened this issue May 18, 2020 · 2 comments
Labels
discussion High-level concept in need of clarification or decision MVP Features for MVP to get product Market Fit

Comments

@AdhamAH
Copy link
Member

AdhamAH commented May 18, 2020

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

  • check this box if you have completed the following:
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Summary

Add the translation helper i18Next
After PR #720 merges it will be easy to divide the work into separate issues depending on the page and components that related to it

Motivation

Showing the translated languages across the whole app

Possible Alternatives

None!

Additional Context

I will wait and see if there are any suggestions or ideas and start to open issues to execute

@AdhamAH AdhamAH added discussion High-level concept in need of clarification or decision MVP Features for MVP to get product Market Fit labels May 18, 2020
@pavel-ilin
Copy link

@AdhamAH The helper function will get all language data from blockstack and then we will import data we need from this function, not from blockstack. Am I understand it correctly?

@AdhamAH
Copy link
Member Author

AdhamAH commented May 22, 2020

That seems the case. I am not sure if there is another idea. I didn't really work with blockstack very much "which I should" or i18next. If from the helpers or blockstack, is there is a different how to add the translation to the components? I mean when using useTranslation or Trans
if no different, then it doesn't matter if from helpers or blockstack. If there is a different then could you please explain a bit or point me to where I can get the info @pavel-ilin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion High-level concept in need of clarification or decision MVP Features for MVP to get product Market Fit
Projects
None yet
Development

No branches or pull requests

2 participants