Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update Disclaimer text and functionality #680

Open
4 of 8 tasks
whoabuddy opened this issue Apr 30, 2020 · 2 comments
Open
4 of 8 tasks

[BUG] Update Disclaimer text and functionality #680

whoabuddy opened this issue Apr 30, 2020 · 2 comments
Assignees
Labels
bug Something isn't working Frontend Issues pertaining to the Front end team invalid This doesn't seem right

Comments

@whoabuddy
Copy link
Contributor

whoabuddy commented Apr 30, 2020

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to address the issue.

Prerequisites

  • check this box if you have completed the following:
    • Reproduced the problem in QA
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Description of the Bug/Issue

There are a few small items that need to be considered/corrected on the Disclaimer that pops up on first login.

Steps to Reproduce

  1. Sign up for a Blockstack ID
  2. Log into the application
  3. Review the disclaimer

Expected Behavior

The display text and button text should match, and the "do not agree" button should do something.

Actual Behavior

  • The disclaimer states By clicking 'I Accept', but the button at the bottom says I AGREE.
  • The Privacy Policy and Terms of Use links need to have some sort of separation, possibly be centered on the container, and links should open in a new window.
  • The paragraphs appear to have extra line endings or do not line up as expected.
  • Small typo: EU General Data Protection Regulation; andYou understand,
  • Who is Mawi Health? YOU AGREE THAT DISPUTES BETWEEN YOU AND MAWI HEALTH
  • This should be [email protected] now YOU CAN OPT-OUT OF THE ARBITRATION AGREEMENT BY CONTACTING [email protected] WITHIN 30 DAYS OF ACCEPTING THESE TERMS.
  • The I DON'T AGREE button doesn't do anything. I'd suggest that it prompts the user that they won't be able to use the app on first click, and on second click logs out the user and redirects

them to another site or a nice "leaving / outbound" message on the way to WHO/CDC facts.

Reproduces How Often

💯

Additional Information

None.

@salvolpe
Copy link
Contributor

salvolpe commented May 7, 2020

@whoabuddy @AdhamAH I'm currently working on the textual typos, but I can't handle the programming ones

@salvolpe salvolpe added Frontend Issues pertaining to the Front end team invalid This doesn't seem right bug Something isn't working labels May 7, 2020
@johnemurphy1
Copy link
Contributor

@whoabuddy @AdhamAH I'll work on this if it still needs help.

@AdhamAH AdhamAH assigned johnemurphy1 and unassigned salvolpe and AdhamAH Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend Issues pertaining to the Front end team invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

4 participants