Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add motion #561

Conversation

AdhamAH
Copy link
Member

@AdhamAH AdhamAH commented Apr 17, 2020

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Do not change the following line aside from replacing YOUR-ISSUE-HERE with the issue this PR fixes

fixes #563 563

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
m

Final Checklist

  • Have you bumped the version in package.json?
    • Second decimal for major change, third decimal for minor change. This can go past 10 i.e. 1.0.9 !=> 1.1.0, 1.0.9 => 1.0.10
    • Read here for more info
  • Have you added any new tests necessary?
  • Is your PR rebased off the most current master?
  • Have you squashed all commits, or if you will merge will you squash all commits?
  • Did you use yarn, not npm?
  • Did you use Material-UI wherever possible?
  • Did you format according to Prettier?
  • Did you run all of your most recent changes locally to make sure everything is working?

@SomeMoosery
Copy link
Member

I'd say before merging this in, let's create an issue where we can discuss how we want transitions to work - if we want them all to transition the same way, or if not which directions, etc...

Great and UX-friendly change though!

@AdhamAH AdhamAH mentioned this pull request Apr 17, 2020
@AdhamAH
Copy link
Member Author

AdhamAH commented Apr 17, 2020

#563 @SomeMoosery
done!

@AdhamAH
Copy link
Member Author

AdhamAH commented Apr 23, 2020

closed because it will be rewritten and changed

@AdhamAH AdhamAH closed this Apr 23, 2020
@AdhamAH AdhamAH deleted the Add-some-motion branch April 23, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animation
2 participants