Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representing signals in VSS tree #727

Open
raksac opened this issue Feb 23, 2024 · 2 comments
Open

Representing signals in VSS tree #727

raksac opened this issue Feb 23, 2024 · 2 comments

Comments

@raksac
Copy link

raksac commented Feb 23, 2024

I am looking for some advice on representing engine ignition state in VSS consistently across the different Vehicle.Powertrain.Type {COMBUSTION, HYBRID, ELECTRIC}.

eg: Vehicle.PowerTrain.CombustionEngine.IsRunning indicates whether the ignition is currently on or off

@erikbosch
Copy link
Collaborator

Good question, what we have in VSS today is among others the signal below which maybe cover parts of what you are looking for.

LowVoltageSystemState:
  datatype: string
  type: sensor
  allowed: [
    'UNDEFINED', # State of low voltage system not known
    'LOCK',      # Low voltage system off, steering lock or equivalent engaged
    'OFF',       # Low voltage system off, steering lock or equivalent not engaged
    'ACC',       # Vehicle Accessories on/living
    'ON',        # Engine start enabled (e.g. ignition on, diesel pre-heating, electrical drive released)
    'START'      # Engine starter relay closed (not applicable for electrical vehicles)
    ]
  description: State of the supply voltage of the control units (usually 12V).

It was originally intended to mimic typical states for a physical ignition switch, but may roughly match "vehicle state" also for keyless vehicles and electrical vehicle. The CombustionEngine.IsRunning signal has a possibly different meaning as it indicates if the engine is rotating. For electrical motors we have no similar signal as of today, even if an app could create a similar conclusion by checking/comparing the motor speed (rpm). There is a related PR #725 where a time counter for electrical vehicles is proposed, in it current version if refer to "READY" state, but as of today we do not have any signal that indicates "READY"

Could you possible say something about your intended use-case. Do you want to monitor if a specific motor (or any motor) is rotating, or are you rather interested in if a specific motor (or any motor) is enabled/ready? Like if you are waiting at a red light with a hybrid vehicle, what information would you like to get? In that case possibly neither the electric motor not the combustion engine are rotating, but they might both be enabled/ready and ready to start delivering power as soon as you press the gas pedal.

@erikbosch
Copy link
Collaborator

MoM: Presented at VSS meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants