-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Analysis Tool "Prettier" Integration #28
Conversation
…ndorse Topic' button is pressed and removes checkmark when 'Unendorse Topic' is pressed
US4: Added backend logic for green endorsement checkmark
…int. Worked locally.
Pull Request Test Coverage Report for Build 11596217818Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All test passed so looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This would be a really helpful tool for our code from now on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Functionality is up and running
Note
This pull request will now replace pull request #25 as the conflict between prettier and eslint could not be resolved on that branch.
Integration Steps
npm run lint -- --fix
to make sure your code in local repo is passing lint tests.prettier-eslint
with the commandnpm install --save-dev prettier-eslint
.prettier-eslint --write "path"
. For this pull request, I use the commandprettier-eslint --write "src/api/*.js"
to format all files within the directorysrc/api
. Note that--write
will modify files in place. If you don't want in-place modification just run without--write
.Relevant Links