Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Analysis Tool "Prettier" Integration #28

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

gpxxlt
Copy link

@gpxxlt gpxxlt commented Oct 30, 2024

Note

This pull request will now replace pull request #25 as the conflict between prettier and eslint could not be resolved on that branch.

Integration Steps

  1. First run npm run lint -- --fix to make sure your code in local repo is passing lint tests.
  2. Install prettier-eslint with the command npm install --save-dev prettier-eslint.
  3. Run prettier-eslint --write "path". For this pull request, I use the command prettier-eslint --write "src/api/*.js" to format all files within the directory src/api. Note that --write will modify files in place. If you don't want in-place modification just run without --write.

Relevant Links

  1. Official docs https://prettier.io/docs/en/integrating-with-linters.html

Akshra Paimagam and others added 4 commits October 10, 2024 18:26
…ndorse Topic' button is pressed and removes checkmark when 'Unendorse Topic' is pressed
US4: Added backend logic for green endorsement checkmark
@gpxxlt gpxxlt self-assigned this Oct 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11596217818

Details

  • 55 of 57 (96.49%) changed or added relevant lines in 10 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 82.669%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/chats.js 1 2 50.0%
src/api/users.js 12 13 92.31%
Files with Coverage Reduction New Missed Lines %
src/user/approval.js 3 87.61%
src/user/reset.js 3 87.5%
Totals Coverage Status
Change from base Build 11490004639: -0.02%
Covered Lines: 22345
Relevant Lines: 25607

💛 - Coveralls

Copy link

@tanoctavius tanoctavius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test passed so looks good!

Copy link

@Akshra-school Akshra-school left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This would be a really helpful tool for our code from now on.

Copy link

@ThomasJXiao ThomasJXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Functionality is up and running

@gpxxlt gpxxlt merged commit d98b88e into f24 Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants