Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QPPSE-2004: Added participation file to S3 and updated the scripts #1469

Merged
merged 1 commit into from
Oct 28, 2024
Merged

QPPSE-2004: Added participation file to S3 and updated the scripts #1469

merged 1 commit into from
Oct 28, 2024

Conversation

sivaksb
Copy link
Contributor

@sivaksb sivaksb commented Oct 24, 2024

Information

  • Downloaded the pariticipation file from FMS, extracted the required information, created the respective files and uploaded it to S3 bucket. And updated the scripts with latest changes as well.

Checklist

  • All JUnit tests pass (mvn clean verify).
  • New unit tests written to cover new functionality.
  • Added and updated JavaDocs for non-test classes and methods.
  • No local design debt. Do you feel that something is "ugly" after your changes?
  • Updated documentation (README.md, etc.) depending if the changes require it.

@sivaksb sivaksb requested a review from Jpec07 as a code owner October 24, 2024 21:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cabedi-icf
cabedi-icf approved these changes Oct 25, 2024
View reviewed changes
Copy link

@cabedi-icf cabedi-icf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine as long as you note you'll have to run It from the tools/scripts/ directory as opposed to the root directory

@sivaksb sivaksb merged commit 2138943 into develop Oct 28, 2024
6 checks passed
@sivaksb sivaksb deleted the feature/QPPSE-2004-Updated_Participation_Process_Scripts branch October 28, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabedi-icf cabedi-icf cabedi-icf approved these changes

@Jpec07 Jpec07 Jpec07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sivaksb @Jpec07 @cabedi-icf