-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-679 Tag commits to main for promotion #1400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsf
changed the title
PLT-679 build main
PLT-679 Add ab2d-main image tags on push to main
Oct 4, 2024
gsf
changed the title
PLT-679 Add ab2d-main image tags on push to main
PLT-679 Tag commits to main for promotion
Oct 5, 2024
ildesenesence
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed - I like how you cleaned up the environment variables in here on top of the functionality changes, much more legible!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/PLT-679
🛠 Changes
Added workflow to trigger bulids on push to main and updated build workflow to push "main" tags to ECR.
ℹ️ Context
We need images we can count on being around for a bit from each to push to main for promotion to prod on release. This allows us to set a lifecycle policy specific to tags with the "main" prefix.
🧪 Validation
See runs at https://github.com/CMSgov/ab2d/actions/runs/11195118631, https://github.com/CMSgov/ab2d/actions/runs/11195323158, and https://github.com/CMSgov/ab2d/actions/runs/11202145951 for successful tests of the release and promote workflows. The push-main workflow (and expected tag updates in ECR) must be checked following merge of this PR.