Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-679 Tag commits to main for promotion #1400

Merged
merged 15 commits into from
Oct 7, 2024
Merged

PLT-679 Tag commits to main for promotion #1400

merged 15 commits into from
Oct 7, 2024

Conversation

gsf
Copy link
Member

@gsf gsf commented Oct 4, 2024

🎫 Ticket

https://jira.cms.gov/browse/PLT-679

🛠 Changes

Added workflow to trigger bulids on push to main and updated build workflow to push "main" tags to ECR.

ℹ️ Context

We need images we can count on being around for a bit from each to push to main for promotion to prod on release. This allows us to set a lifecycle policy specific to tags with the "main" prefix.

🧪 Validation

See runs at https://github.com/CMSgov/ab2d/actions/runs/11195118631, https://github.com/CMSgov/ab2d/actions/runs/11195323158, and https://github.com/CMSgov/ab2d/actions/runs/11202145951 for successful tests of the release and promote workflows. The push-main workflow (and expected tag updates in ECR) must be checked following merge of this PR.

@gsf gsf requested a review from oluwolenpbc October 4, 2024 20:36
@gsf gsf self-assigned this Oct 4, 2024
@gsf gsf requested a review from a team as a code owner October 4, 2024 20:36
@gsf gsf changed the title PLT-679 build main PLT-679 Add ab2d-main image tags on push to main Oct 4, 2024
@gsf gsf changed the title PLT-679 Add ab2d-main image tags on push to main PLT-679 Tag commits to main for promotion Oct 5, 2024
@gsf gsf requested review from a team and removed request for oluwolenpbc October 7, 2024 14:40
Copy link
Contributor

@ildesenesence ildesenesence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed - I like how you cleaned up the environment variables in here on top of the functionality changes, much more legible!

@gsf gsf merged commit 9d838c7 into main Oct 7, 2024
9 checks passed
@gsf gsf deleted the plt-679-build-main branch October 7, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants