-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-136 Run e2e tests on impl environment #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsf
reviewed
Nov 27, 2023
@@ -0,0 +1,100 @@ | |||
name: GitHub Actions Workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for PLT-136 then we need two workflows:
- deploy.yml to deploy code to an environment (in this case, impl)
- e2e-test.yml to run e2e tests on an environment (also on the impl in this case)
The deploy and test on impl should run on push to master and manual dispatch.
gsf
changed the title
adding github actions to ab2d repo
PLT-136 Run e2e tests on impl environment
May 20, 2024
Pull request trigger will be handled in another workflow.
Sadibhatla
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/PLT-136
🛠 Changes
Added workflow for running e2e tests on the impl environment.
ℹ️ Context for reviewers
This e2e-test workflow should allow us to gain confidence in deploying while simplifying our test pipelines by running tests directly against resources in the impl environment.
✅ Acceptance Validation
We may need to merge this before we can test running the workflow.
🔒 Security Implications
None, these tests are run on self-hosted runners within our internal network.