Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken export of boost linking flags #70

Closed
tskisner opened this issue Jan 21, 2022 · 2 comments
Closed

Broken export of boost linking flags #70

tskisner opened this issue Jan 21, 2022 · 2 comments

Comments

@tskisner
Copy link
Member

Hello @arahlin , just a heads up that the recent change to Spt3gBoostPython.cmake:

set(CMAKE_FIND_PACKAGE_PREFER_CONFIG TRUE)

has broken the ability for the so3g package to get boost linking information by using the build/cmake-install/Spt3gConfig.cmake file. Can you give more information about what problem that was trying to fix? I have not yet dug into this any deeper to see why the various Boost::filesystem, Boost::python, etc are no longer available, but thought I would try to get more information about this change first.

@arahlin
Copy link
Member

arahlin commented Jan 22, 2022

Interesting, how do you install boost, what version are you using, and what are the errors you get? Newer boost versions ship with their own cmake config files that are supposed to provide the same variables and targets, and newer versions of cmake issue lots of warnings about potential mismatches if the cmake find module is used instead of the boost config. This flag just suppresses that warning and tries to use the config if it can find it.

@arahlin
Copy link
Member

arahlin commented Jan 25, 2022

Fixed with #71

@arahlin arahlin closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants