Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G3MapVectorInt and G3MapInt should use int64 #122

Closed
arahlin opened this issue Oct 12, 2023 · 0 comments · Fixed by #140
Closed

G3MapVectorInt and G3MapInt should use int64 #122

arahlin opened this issue Oct 12, 2023 · 0 comments · Fixed by #140
Assignees
@nwhitehorn

Comments

@arahlin
Copy link
Member

arahlin commented Oct 12, 2023

Currently these use int32, which is inconsistent with G3VectorInt.
arahlin added a commit that referenced this issue Feb 6, 2024
@arahlin
Efficient storage of G3MapInt and G3MapVectorInt objects
c12160a 
Use int64_t for in-memory representation of integer values, but store as 8-, 16-
or 32- bit integers on disk, depending on bit depth of the underlying data.
Backwards compatible with v1 int32 G3Map objects.

Closes #122.
@arahlin arahlin mentioned this issue Feb 6, 2024
Merged
arahlin added a commit that referenced this issue Feb 20, 2024
@arahlin
Efficient storage of integer G3Map and G3Vector objects (#140)
cc46e8d 
Use int64_t for in-memory representation of integer values, but store as 8-, 16-
or 32- bit integers on disk, depending on bit depth of the underlying data.
Backwards compatible with v1 int32 G3Map objects.

Closes #122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nwhitehorn nwhitehorn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Efficient storage of integer G3Map and G3Vector objects CMB-S4/spt3g_software
2 participants
@arahlin @nwhitehorn