Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caches service? #8

Open
CHH opened this issue Nov 22, 2016 · 0 comments
Open

Remove caches service? #8

CHH opened this issue Nov 22, 2016 · 0 comments
Milestone

Comments

@CHH
Copy link
Owner

CHH commented Nov 22, 2016

Currently all individual caches are services in a separate Pimple container, which is set as the caches service of the application.

This makes it easy to pass the complete collection of defined caches to something, but at the same time makes it a bit more work to define or extend just a single cache at a time, because you have to extend the caches service first.

The question is: Is anyone using the caches service and would it be acceptable to remove this service and to setup caches as services of the application's container (e.g. cache.default)?

This change would also bring it more in line with other service providers, which create services on the application's container, e.g. Doctrine.

@CHH CHH added the discussion label Nov 22, 2016
@CHH CHH modified the milestone: v3.0.0 Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant