Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dangling reference in Construct_center_3(Circle_3) #8586

Open
wants to merge 7 commits into
base: 5.6.x-branch
Choose a base branch
from

Commits on Nov 3, 2024

  1. Fix dangling reference in Construct_center_3(Circle_3)

    This fixes the issue, but it could still be broken e.g. by a kernel
    that is based on a CGAL kernel, but redefines the Sphere_3 and
    with Sphere_3-functor that would not return a const& (or in that
    case the custom kernel needs to define the appropriate functors
    too...)
    
    But so much breaks into this configuration, that it's out of scope
    for this fix.
    MaelRL committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    ee451ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd2fca2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    425fe50 View commit details
    Browse the repository at this point in the history
  4. Remove obsolete debug cout

    MaelRL committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    69c9aba View commit details
    Browse the repository at this point in the history
  5. Revert sidechange

    MaelRL committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    b32491a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    181ccd2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b02776b View commit details
    Browse the repository at this point in the history