Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names: drop usage of internal_id #284

Open
ntarocco opened this issue Dec 13, 2024 · 0 comments · May be fixed by #300
Open

Names: drop usage of internal_id #284

ntarocco opened this issue Dec 13, 2024 · 0 comments · May be fixed by #300
Assignees
@jrcastro2 @kpsherva
Milestone
SSPN

Comments

@ntarocco
Copy link
Contributor

After long discussions, the internal_id is actually not needed. We can keep it empty, to avoid creating yet another Alembic recipe to drop it.

Apply the needed changes to reflect this implementation. In the names vocabulary, we will have:

  1. the full ORCiD dump, where the primary key is the ORCiD
  2. the full CERN users db dump, where the primary key is the Person ID
  3. when a CERN user also has an ORCiD, the ORCiD name will be enriched with extra CERN information, and the CERN name will be unlisted so that it won't be visible.
@ntarocco ntarocco added this to the SSPN milestone Dec 13, 2024
@jrcastro2 jrcastro2 moved this to In progress in Sprint Q4/2024 🎄 Dec 17, 2024
jrcastro2 added a commit to jrcastro2/invenio-vocabularies that referenced this issue Dec 19, 2024
@jrcastro2
names: remove internal_id
4716137 
* closes CERNDocumentServer/cds-rdm#284
@jrcastro2 jrcastro2 mentioned this issue Dec 19, 2024
Closed
jrcastro2 added a commit to jrcastro2/invenio-vocabularies that referenced this issue Dec 19, 2024
@jrcastro2
names: remove internal_id
ca50fd9 
* closes CERNDocumentServer/cds-rdm#284
jrcastro2 added a commit to jrcastro2/cds-rdm that referenced this issue Dec 19, 2024
@jrcastro2
names: remove internal id from sync
40052c2 
* Always sync CERN name, if orcid is present
  tag CERN name as unlisted
* closes CERNDocumentServer#284
@jrcastro2 jrcastro2 linked a pull request Dec 19, 2024 that will close this issue
Open
@jrcastro2 jrcastro2 moved this from In progress to In review 🔎 in Sprint Q4/2024 🎄 Dec 19, 2024
jrcastro2 added a commit to jrcastro2/cds-rdm that referenced this issue Dec 19, 2024
@jrcastro2
names: remove internal id from sync
b31ac43 
* Always sync CERN name, if orcid is present
  tag CERN name as unlisted
* closes CERNDocumentServer#284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrcastro2 jrcastro2

@kpsherva kpsherva

Labels
None yet
Projects
None yet
Milestone
SSPN
Development

Successfully merging a pull request may close this issue.

names: remove internal id from sync jrcastro2/cds-rdm
3 participants
@ntarocco @jrcastro2 @kpsherva