Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test rendering the vignette on mac and Windows in CI #206

Open
dylanhmorris opened this issue Oct 2, 2024 · 2 comments
Open

Test rendering the vignette on mac and Windows in CI #206

dylanhmorris opened this issue Oct 2, 2024 · 2 comments

Comments

@dylanhmorris
Copy link
Collaborator

Since the rendering of the pkgdown site confirms the vignette runs, we exclude running it from the Ubuntu R CMD check for efficiency, but we probably want to confirm it runs on mac and Windows.

@gvegayon
Copy link
Member

gvegayon commented Oct 2, 2024

Although I am all for rebuilding vignettes using different flavors of OS, I just want to ensure we all are aware of the option of sharing pre-built vignettes; see: this r-opensci article about pre-computed vignettes, the note in this section of the R pkgs book, and the section "Condition code in the code package on availability of the data package" of this paper about drat.

@seabbs
Copy link
Collaborator

seabbs commented Oct 2, 2024

We use pre-built vignettes in epinowcast etc with actions to keep them up to date. It works and is fine but its really annoying to have to store the figures etc in the repo so I would avoid if we can/for as long as possible

I wouldn't personally run the vignettes across platform and leave the unit tests for checking that but I don't think its harmful to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants