Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should SampledValues allow pytrees or only arrays? #315

Closed
gvegayon opened this issue Jul 24, 2024 · 2 comments
Closed

Should SampledValues allow pytrees or only arrays? #315

gvegayon opened this issue Jul 24, 2024 · 2 comments
Labels
discussion

Comments

@gvegayon
Copy link
Member

Good question. I would say yes, keep things as ArrayLike objects, but pytrees should be, in principle, OK. Since I'm making the SampledValue a namedtuple, I'm taking this out and we can leave it for a later discussion if we want to enforce a type.

Originally posted by @gvegayon in #262 (comment) Question by @dylanhmorris
@damonbayer
Copy link
Collaborator

Related: #308

@damonbayer
Copy link
Collaborator

Closed in #441

@damonbayer damonbayer closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvegayon @damonbayer