Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jaccard index is running significantly more comparisons than needs to be performed #182

Open
Tracked by #184
slsevilla opened this issue Feb 23, 2024 · 0 comments
Open
Tracked by #184
Labels
bug Something isn't working HighPriority

Comments

@slsevilla
Copy link
Contributor

slsevilla commented Feb 23, 2024

Description of the bug

Running champagne on 12 samples with three contrasts. Checked on the runlogs since the pipeline was still in progress and noticed that JACCARD_INDEX populated over 1800 jobs!

[7b/3bdb74] process > CHIPSEQ:CALL_PEAKS:JACCARD_INDEX (macs_broad H3K4me1 ... [ 92%] 1747 of 1892

This is because of the way the input is being iterated here:

Right now the index is being run on every sample:peak_caller comparison possible. Instead a single matrix should be created for each sample, comparing peak_callers within a sample.

@slsevilla slsevilla added bug Something isn't working HighPriority labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HighPriority
Projects
None yet
Development

No branches or pull requests

1 participant