Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in rule bam2bg when running "no_dedup" option #123

Closed
epehrsson opened this issue Feb 15, 2024 · 1 comment · Fixed by #127
Closed

Error in rule bam2bg when running "no_dedup" option #123

epehrsson opened this issue Feb 15, 2024 · 1 comment · Fixed by #127
Assignees

Comments

@epehrsson
Copy link
Collaborator

epehrsson commented Feb 15, 2024

The pipeline fails on bam2bg (and others downstream) when running with "no_dedup" option due to mismatch with column names.

Solution: Replace "nodedup" with "no_dedup"

workflow/scripts/_get_nreads_stats.py, line 29

-stats["nodedup_nreads_genome"] = sum(list(nodedup_idxstats[nodedup_idxstats[0].isin(list(genomelen[0]))][2]))
+stats["no_dedup_nreads_genome"] = sum(list(nodedup_idxstats[nodedup_idxstats[0].isin(list(genomelen[0]))][2]))
-stats["nodedup_nreads_spikein"] = sum(list(nodedup_idxstats[nodedup_idxstats[0].isin(list(spikeinlen[0]))][2]))
+stats["no_dedup_nreads_spikein"] = sum(list(nodedup_idxstats[nodedup_idxstats[0].isin(list(spikeinlen[0]))][2]))

workflow/scripts/_make_alignment_stats_table.R, line 54

-                 "nodedup_nreads_genome",
+                 "no_dedup_nreads_genome",
-                 "nodedup_nreads_spikein",
+                 "no_dedup_nreads_spikein",

workflow/scripts/_make_library_norm_table.R, line 49

-for (dedup_type in c("dedup_nreads_genome","nodedup_nreads_genome")){
+for (dedup_type in c("dedup_nreads_genome","no_dedup_nreads_genome")){

workflow/scripts/_make_library_norm_table.R, line 73
+ df$dedup_type=gsub("no","no_dedup",df$dedup_type)

@epehrsson
Copy link
Collaborator Author

Recapitulated with test data, but only when using "library" normalization instead of "spikein"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants