Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing python 3.12 issues for MacOS #26

Merged
merged 44 commits into from
Sep 4, 2024

Conversation

spirosmaggioros
Copy link
Member

Issues

  • There was an issue with tensors in mlp torch as we were passing np.float32 but in MLPDataset class, this should've returned torch.Tensor
  • Updated some packages to work with latest macos and python 3.12
  • Removed conda environment from packages as we dont really need it
  • Fixed convergence errors that MLP had with scikit learn(LinearSVC, LinearSVR). We had to pass dual=False and update the loss function instead of passing 1M max_iter as an argument

@spirosmaggioros spirosmaggioros self-assigned this Sep 1, 2024
@spirosmaggioros spirosmaggioros added the bug Something isn't working label Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (00c80d5) to head (bae560a).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
spare_scores/mlp.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   81.15%   81.01%   -0.15%     
==========================================
  Files          11       11              
  Lines        1385     1385              
==========================================
- Hits         1124     1122       -2     
- Misses        261      263       +2     
Files with missing lines Coverage Δ
spare_scores/mlp_torch.py 75.00% <100.00%> (ø)
spare_scores/svm.py 78.69% <100.00%> (ø)
spare_scores/mlp.py 70.64% <50.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@AlexanderGetka-cbica AlexanderGetka-cbica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlexanderGetka-cbica AlexanderGetka-cbica merged commit d22e18a into CBICA:main Sep 4, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants