From 50678cd74c99f8a74e6fa15a6ac132f8ddac9b6a Mon Sep 17 00:00:00 2001 From: "Low Jun Kai, Sean" <42912708+seanlowjk@users.noreply.github.com> Date: Fri, 4 Mar 2022 16:12:59 +0800 Subject: [PATCH 1/2] Update to v3.4.2 (#896) --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 45a5c3d46..43640b03f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "CATcher", - "version": "3.4.1", + "version": "3.4.2", "main": "main.js", "scripts": { "postinstall": "npm run postinstall:electron && electron-builder install-app-deps", From 49cceff89789a239a1bfe7f26ed0c6ed01d4387a Mon Sep 17 00:00:00 2001 From: "Low Jun Kai, Sean" <42912708+seanlowjk@users.noreply.github.com> Date: Sun, 17 Apr 2022 14:12:19 +0800 Subject: [PATCH 2/2] Hotfix GithubService areUsersAssignable bug (#926) There is a bug with the retrieval of the assignees where not all assignees are retrieved, causing unwanted errors to be thrown. Let's hotfix this temporarily be removing the errors to be thrown and do a proper fix in the next official release. --- src/app/core/services/github.service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/core/services/github.service.ts b/src/app/core/services/github.service.ts index 50071ae1b..15c8acc6c 100644 --- a/src/app/core/services/github.service.ts +++ b/src/app/core/services/github.service.ts @@ -274,7 +274,7 @@ export class GithubService { map((assignables: string[]) => assignees.forEach((assignee) => { if (!assignables.includes(assignee)) { - throw new Error(`Cannot assign ${assignee} to the issue. Please check if ${assignee} is authorized.`); + // throw new Error(`Cannot assign ${assignee} to the issue. Please check if ${assignee} is authorized.`); } }) )