[FEAT] 예약 취소 요청 구현 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-halo
approved these changes
Mar 7, 2024
| @@ -6,7 +6,8 @@ | |||
|
|
|||
| @RequiredArgsConstructor | |||
| public enum ReservationSuccessType implements SuccessType { | |||
| RESERVATION_MEMBER_DEFAULT_INFO_GET_SUCCESS(HttpStatus.OK, "회원의 기본 예약 정보 조회에 성공하였습니다."); | |||
| RESERVATION_MEMBER_DEFAULT_INFO_GET_SUCCESS(HttpStatus.OK, "회원의 기본 예약 정보 조회에 성공하였습니다."), | |||
There was a problem hiding this comment.
SUCCESS_GET_MEMBER_DEFAULT_RESERVATION
SUCCESS_CANCLE_RESERVATION
이런 변수명은 어떤지,,(사실 취향 차이같아요 ㅋㅋ) 보다보니 궁금한 게 회원 기본 예약 정보 조회와 예약 취소 성공은 같이 상태 구분에 쓰이는 케이스가 아니고 그냥 단지 성공했다는 공통점만 존재하는 것 같은데 왜 enum 클래스로 묶으신 건지 궁금해요.
There was a problem hiding this comment.
SuccessType을 구현하는 클래스로 따로 만든 이유는 HttpStatus가 달라질 수도 있기 때문입니다!! 같은 성공이더라고 httpstatus가 달라질 수 있거든요! 대부분 200 OK와 201 created로 지정해서 더욱 중복되어 보이는 것 같긴합니다 ㅎㅎ 변수명은 다른 패키지의 SuccessType과 ExceptionType 모두 한번 리팩토링 진행하면서 통일하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛄 PR 타입
🛄 반영 브랜치
🛄 변경 사항
🛄 테스트 결과
🛄 MEMO