Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys.exit(0) when amount == 0 or amount < self.min_amount #236

Closed
MEdGalo opened this issue Nov 8, 2021 · 2 comments
Closed

sys.exit(0) when amount == 0 or amount < self.min_amount #236

MEdGalo opened this issue Nov 8, 2021 · 2 comments

Comments

@MEdGalo
Copy link

MEdGalo commented Nov 8, 2021

Hi,

Why do you return sys.exit(0), instead of sys.exit(1) when amount == 0 or amount < self.min_amount ?
I run it in a simple while loop script in crontab, and it works fine. Except when it meets either of the above criteria, then it goes in an infinite loop and cron then keeps the jobs stacking.
I solve this problem with a timeout, but I guess it would be nicer if it just gives a sys.exit(1). But if there is a specific reason why it should give 0, then I really like to know.

Thanks for making this handy tool.

@C-Otto
Copy link
Owner

C-Otto commented Nov 8, 2021

Related to #185

@C-Otto C-Otto closed this as completed in f6b3049 Nov 8, 2021
@C-Otto
Copy link
Owner

C-Otto commented Nov 8, 2021

Thanks, I agree, 0 should only be used for successful rebalances (or things like "list channels").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants