Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lnd support #46

Closed
C-Otto opened this issue Apr 13, 2021 · 5 comments
Closed

Add lnd support #46

C-Otto opened this issue Apr 13, 2021 · 5 comments
Labels
enhancement New feature or request lnd Features regarding the lightning network daemon p2-should Helpful for many users / in many situations, but not strictly necessary

Comments

@C-Otto
Copy link
Owner

C-Otto commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
As a user who also runs a lnd node, entering the corresponding transaction/address details is very time consuming. I'd like BitBook to help me as much as possible.

Describe the solution you'd like
I'd like to let BitBook work with lnd so that I don't have to copy-paste a lot of data. Direct RPC support would be nice, but I'd be happy creating a few files based on lncli output (e.g. lncli wallet listsweeps > sweeps.json) and parse these from within BitBook (e.g. read-lnd-sweeps-file /tmp/sweeps.json).

Describe alternatives you've considered
Copy-pasting all data manually. The wizard (#27) might make that less frustrating, but it's still a lot of unnecessary work.

@C-Otto
Copy link
Owner Author

C-Otto commented Apr 15, 2021

Optimization idea: mark channel address as owned if all inputs are owned
EDIT: Wasn't necessary in my case, possibly because I already have information for the inputs (by following the coins / other outputs).

@C-Otto
Copy link
Owner Author

C-Otto commented Apr 15, 2021

What about labels which are set by the user?

@C-Otto
Copy link
Owner Author

C-Otto commented Apr 16, 2021

Also mark channels as owned if they were opened by the remote peer? Most likely, there are owned funds in the channel, which we would like to track. ❌ No: otherwise, we'd need to track the foreign coins that funded the channel. We're only interested in the coins that were sent to us (when the channel closed), and we cannot track those (they result out of off-chain transactions).

@C-Otto
Copy link
Owner Author

C-Otto commented Apr 17, 2021

Gather more information about channel close outputs (especially HTLCs) by inspecting the scripts. See https://github.com/alexbosworth/bolt03.
#89

@C-Otto
Copy link
Owner Author

C-Otto commented Apr 18, 2021

Cooperative closes: mark the other output as foreign (if not marked as owned), it belongs to the remote node ✔️ #74

@C-Otto C-Otto added the p2-should Helpful for many users / in many situations, but not strictly necessary label Apr 20, 2021
@C-Otto C-Otto added the lnd Features regarding the lightning network daemon label Apr 20, 2021
@C-Otto C-Otto closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lnd Features regarding the lightning network daemon p2-should Helpful for many users / in many situations, but not strictly necessary
Projects
None yet
Development

No branches or pull requests

1 participant