Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ideas #14

Open
C-Kenny opened this issue Jul 27, 2020 · 4 comments
Open

Refactor ideas #14

C-Kenny opened this issue Jul 27, 2020 · 4 comments

Comments

@C-Kenny
Copy link
Owner

C-Kenny commented Jul 27, 2020

Divide classes up into managed objects such as diamonds, bezier fins etc for easier state management

@C-Kenny
Copy link
Owner Author

C-Kenny commented Jan 5, 2021

  • global state to be in classes
  • split into separate files now that the visualizer is approaching > 1000 lines

@C-Kenny C-Kenny changed the title Refactor global state to be in classes Refactor ideas Jan 5, 2021
@C-Kenny
Copy link
Owner Author

C-Kenny commented Jan 17, 2021

Moved global state initialization into own function. Visualizer has now reached > 1000 lines including comments.

@C-Kenny
Copy link
Owner Author

C-Kenny commented Feb 7, 2021

Moved global init state into own function, is now independent from setup(); which allows the Visualizer to be reset when a new song is loaded.

Changed in 7f0fc46

Moving the diamonds, fins, background states into their own classes structure still needs to be done.

@C-Kenny
Copy link
Owner Author

C-Kenny commented Feb 7, 2021

Now that we're getting to the stage of different foregrounds/backgrounds it would be nice to create "scenes" rather than toggling elements.

https://github.com/friedrichweise/Visualizer provides a good example of splitting into different scenes which are loaded depending on what state is desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant