Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor line not visible with NO_COLOR #238

Open
samuelallan72 opened this issue Apr 17, 2024 · 2 comments
Open

Cursor line not visible with NO_COLOR #238

samuelallan72 opened this issue Apr 17, 2024 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@samuelallan72
Copy link

samuelallan72 commented Apr 17, 2024

when I have NO_COLOR=true in the environment, dua i won't display the cursor line:

1713397567

It also seems to appear when I press C to display file count:

1713397799

But even then, sometimes it displays the cursor line when moving up, but disappears when moving down.

It works fine if I:

unset NO_COLOR
dua i
@Byron Byron added bug Something isn't working help wanted Extra attention is needed labels Apr 18, 2024
@Byron
Copy link
Owner

Byron commented Apr 18, 2024

Thanks for letting me know!

It has never been tested with no-color, and I am surprised it even respects it. Further, it's nice to see that it is so close to actually working.

A solution might be to slightly change the style once no-color is detected.

@samuelallan72
Copy link
Author

Nice, yes I think a lot of low level tui libraries support NO_COLOR. :)

I usually run a light theme with NO_COLOR, so often hit edge cases with these things. 😂 Please let me know if there's anything you'd like tested more from a NO_COLOR or light theme environment, I'm happy to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants