Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

It would help significantly if you could test qpid-bow against qpid-proton 0.27.1 #20

Open
astitcher opened this issue May 20, 2019 · 5 comments

Comments

@astitcher
Copy link

This is the last version prior to completely rewriting the IO in Python rather than using C as the pinned 0.24 version does.

Doing this will enable us to know if qpid-bow is using any symbols that are no longer exported by the library. And we can take some action to fix this.

Due to some last minute breakage, the 0.28 release (the version after the IO rewrite) is known not to work with external loops - This is PROTON-2051

@nugend
Copy link

nugend commented Aug 16, 2019

I was investigating this because I have a need to upgrade to a new version of qpid proton due to a dependency conflict. Independent of the IO rewrite, there's an incompatibility due to EventBase no longer being exported from proton.reactor as of 0.25

afaict though, the class is only used for type checking. I'm presuming this was so that the functions would also accept ApplicationEvent?

@astitcher
Copy link
Author

Hmm, I'm not entirely sure what you mean about EventBase. as far as I remember (I'm not in front of the source right now) applications should never need EventBase they only use ApplicationEvent and handle on_foo_event functions.

But I'll have another look when I get back to my computer.

@nugend
Copy link

nugend commented Aug 17, 2019

@maruno
Copy link
Contributor

maruno commented Aug 20, 2019

You're right that EventBase is only used for type-hinting, it can be replaced with the new one.

@astitcher
Copy link
Author

I've just checked the proton source and you should use Event as the type hint. You can't get anything else in the handlers unless you actually send an ApplicationEvent yourself. And in that case you can only get an ApplicationEvent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants