Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different radiuses on corners #39

Open
jaapvanhoek opened this issue Feb 16, 2022 · 2 comments
Open

Add support for different radiuses on corners #39

jaapvanhoek opened this issue Feb 16, 2022 · 2 comments

Comments

@jaapvanhoek
Copy link

In a project I am working on I get an array of points with different radiuses for each point(corner). I forked this repository and made the changed (one line) that work for me.
The problem is, this solution lacks the following:

  • not backwards compatible
  • no support for multiple subpaths
  • when the overlap filter removes items from the array the indexes don't line up any more.

Looking forward to your opinion.

@BrunoFenzl
Copy link
Owner

BrunoFenzl commented Feb 17, 2022

Hey @jaapvanhoek Thats an interesting idea! Thanks for the feature request, I imagine this could be useful. As you pointed out there are a few challenges and a few things would need to be changed to make this happen. The param radius in the signature of roundCommands should be a number | number[] so users could keep it simple and the library stays backward compatible. If it's an array, it could be filtered together with overlapping points. I think this could work for subpaths as well.
Would you have time/interest in trying this out?

@jaapvanhoek
Copy link
Author

Hi @BrunoFenzl what do you think of this solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants