Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time: Find a better solution from scrollIntoView #21

Open
svanherk opened this issue Aug 31, 2018 · 0 comments
Open

Time: Find a better solution from scrollIntoView #21

svanherk opened this issue Aug 31, 2018 · 0 comments

Comments

@svanherk
Copy link
Contributor

@dbatiste: Normally I think the actual opener (the element the user will click or focus on) should have d2l-dropdown-opener class. This class is how the dropdown logic locates the focusable opener. The d2l-dropdown-opener-behavior has some logic that I think expects this, for instance to apply focus to the opener when the use hits [Escape] inside the dropdown content. There's likely a couple more little things like that. So in this case, I think it should be on the input, but perhaps there is a reason it's not in this case?

Seems like this is not setup as Dave B suggests due to the ScrollIntoView requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant