Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android > App Crash > Additional functions #31

Closed
KirstenStake opened this issue Feb 23, 2021 · 4 comments
Closed

Android > App Crash > Additional functions #31

KirstenStake opened this issue Feb 23, 2021 · 4 comments

Comments

@KirstenStake
Copy link
Contributor

When using plugin v3.0.0 my app crashes on Android with no error messages when calling functions:

  • BranchDeepLinks.generateShortUrl()
  • BranchDeepLinks.showShareSheet()

I haven't tried some other functions other than those two, so some of the others might crash the app too.

When downgrading to v2.0.0 there are no issues and everything works as expected.

Additional environment information:

  • Ionic 5
  • Capacitor
  • Angular 11
@stevecarlton
Copy link

+1, seeing this as well. Seems like this plugin is being neglected by the Branch team, no significant updates in 5 months.

@jdee @tafelnl @gfletcher-branch can you please look into merging @KirstenStake's push request (#32 ) fixing this as well as #33 for iOS builds) or have someone on the branch team take a look?

@selected-pixel-jameson
Copy link

Sounds about right. I don't know that I've ever seen an actual response from their team members in this repo.

@tafelnl
Copy link
Contributor

tafelnl commented Apr 23, 2021

I am not on the branch team. So unfortunately I cant help. I could try to claim ownership of this repo though and transfer it to the capacitor community.

Though, I do not have very much time on my hands, so if anyone would like to volunteer for this, that would be awesome

@KirstenStake
Copy link
Contributor Author

PR was merged in. closing issue thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants