Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UoI linear_model fit function should be split into a selection and estimation function #68

Open
pssachdeva opened this issue Dec 14, 2018 · 1 comment
Open

UoI linear_model fit function should be split into a selection and estimation function #68

pssachdeva opened this issue Dec 14, 2018 · 1 comment
Labels
2.0.0 hard

Comments

@pssachdeva
Copy link
Collaborator

Currently, the selection and estimation bootstrapping loops are in the fit function together. Putting them in separate functions will help readability and allow for better testing.
@akumar01
Copy link
Contributor

akumar01 commented Aug 9, 2019

Resolved by #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0.0 hard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JesseLivezey @akumar01 @pssachdeva