Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#00] rank type 고치기 #98

Merged
merged 2 commits into from
May 28, 2024
Merged

[#00] rank type 고치기 #98

merged 2 commits into from
May 28, 2024

Conversation

namewhat99
Copy link
Contributor

이슈

  • #issue_number

체크리스트

  • A 구현
  • B 구현

고민한 내용

  • 무슨 이유로 어떻게 코드를 변경했는지
  • 어떤 부분에 리뷰어가 집중해야 하는지
  • 기술적 고민

@namewhat99 namewhat99 requested a review from koomin1227 May 28, 2024 15:25
));
result.forEach(
(result) => (result.rank = parseInt(String(result.rank), 10)),
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orm 에서 강제로 문자열로 변환해서 주는거는 처음 알았네요...

@koomin1227 koomin1227 merged commit 068353c into develop May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants