[#61] refreshToken 보내면 새로운 token 들 반환 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koomin1227
requested changes
Apr 14, 2024
src/login/login.module.ts
Outdated
| controllers: [LoginController], | ||
| providers: [LoginService, JwtStrategy], | ||
| }) | ||
| export class LoginModule {} |
There was a problem hiding this comment.
auth module에 합치는게 더 낫지 않을까 생각됩니다. 중복되는 코드도 많고 그래서요
koomin1227
approved these changes
Apr 16, 2024
| }); | ||
| } catch (e) { | ||
| if (e instanceof TokenExpiredError) { | ||
| throw new UnauthorizedException(); |
| @@ -34,4 +34,9 @@ export class AuthController { | |||
| ) { | |||
| return await this.authService.checkSejongStudent(body, userId); | |||
| } | |||
|
|
|||
| @Post('refresh') | |||
| public refreshTokens(@Body('refreshToken') refreshToken: string) { | |||
There was a problem hiding this comment.
이렇게 하면 refresh token으로 숫자가 오면 어떻게 되나요? 400이 나오나요 500이 나오나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
고민한 내용